Enable search and notifications for email addresses using the "+" syntax
A lot of people use a syntax such as troyhunt+foo@hotmail.com where foo is a unique identifier for the site. They do this so that if they begin getting spammed, they can identify the source their email came from.
At the moment, HIBP treats this is a totally unique email address so if I've search for the parent email address without the "+" syntax, it won't be found. This idea is to ensure that searches and notifications recognise the syntax and return addresses that are logically still the same account.
One thing HIBP would also need to do is specify which account alias was in the breach or paste. For example, I would want to know that it was troyhunt+bar@hotmail.com that was exposed in the XYZ breach.
Edit: Just to put the value of this into context, I've just run some stats on the Adobe breach. Of the the 152,989,508 rows in the dump, only 49,905 email addresses have a "+" in the address so that's 0.03% of entries. That number is also a bit high as it includes junk entries. I'm definitely not ruling this idea out - it's still planned - I just wanted to give a sense of how useful it would be.
Edit: To add to this idea, Robert's comment about a period in the email is also very valid. I'd want to be very clear about the ubiquity of this practice across mail providers, but it's certainly a good suggestion and worth further investigation.
-
Wout Mertens commented
I would be perfectly happy if this were only implemented for new breaches and if it didn't tell me the exact tagged e-mail address.
Under these conditions you would only need to canonicalize email addresses as they come in and the rest of the code would work as-is. Convert to lowercase, strip generic subfields, add a special case for gmail dots and yahoo hyphens, store it and that would be it.
-
Anonymous commented
Would it not be possible to just add a, "This email address has tags," checkbox to the search, with a small tooltip telling confused people what it is? That way the extra code to search for tagged addresses never gets executed for the 99% of people it's not relevant for.
-
Nick commented
You should not be deliberately programming data leaks into HIBP!
Just because Google started to support this "+tag" idea does not undo the fact that + has been a valid char left of the @ in internet email addresses since there have been internet email addresses. Go read the RFCs.
Now, if you want to do it on a domain-by-domain basis after verifying that a domain that supports "+tag" otherwise does not allow + on the left of @ in any other email address, all power to you, but please do not do it for all domains "because Google supports it". The internet has already had far too much non-standards conformant cr*p to deal with because of attitudes like that in past (when variously Sun, IBM and MS have been the problem actors).
-
Cory Charlton commented
I've recently started switching registrations to use the "+" syntax and would love it if this feature was supported. As it stands I am adding subscriptions for every "+" variation I have used (or remember using)
-
Dylan Katz commented
I use this feature quite often, but have been hesitant to use it recently due to haveibeenpwned's not supporting it. This would be an awesome function.
-
Adding both the full address with the "+" and a normalised ones without it would be an option, but it's difficult to do retrospectively and would mean enumerating back through hundreds of millions of records (I can't just query for everything containing a plus due to the data structure).
I'll continue to monitor this and if it either becomes easier to implement or more popular with users (it's still *extremely* rare) then I'll reassess.
-
Anonymous commented
How about using the canonical e-mail as an index field, and adding a second e-mail field, containing the actual email from the breach ?
This way, if guillaume+hello@whatever.com is found in a breach, create a record in the database for "guillaume@whatever.com".
-
Anjor commented
This is a neat idea, and I'd really like to see it implemented in HIBP.
Having said that, I also question how far should HIBP go and adjust for the quirks of individual email providers. Generic sub-addressing is a standard (rfc5233) and implemented by nearly every provider, but going all the way would be much more involved than that.
A few examples of such quirks:
1) AFAIK, dot addressing is something specific to gmail. Other email providers (like Hotmail) treat JaneDoe@outlook.com and Jane.Doe@outlook.com differently.
2) For plus addressing, Yahoo allows users to create a separate prefix for disposable addresses e.g. JaneDoe@yahoo.com will have addresses of type "CustomPrefix-foo@yahoo.com" and "CustomPrefix-bar@yahoo.com" (Also note the - instead of +)
3) For domain equivalence, gmail.com and googlemail.com are equivalent, but contrary to what one of the comment below claims, JaneDoe@outlook.com and JaneDoe@hotmail.com are different accounts.
Generic plus addressing is a good idea, but I feel implementing support for every possible email address equivalence might not be as useful for the effort involved, especially when the other problems are much more easily solvable by registering just one more account in HIBP.
-
The problem with a domain alias is that it's even less predictable than the "+" pattern. There's no assurance whatsoever that all domains will continue to work consistently in an interchangeable fashion nor is there necessarily a canonical list of them for each email provider.
I'd also be surprised if if many people actually used them in that way. Per the stats here, use of the "+" syntax is extremely rare and I can only imagine that domain substitution is even less so.
-
Paul M Edwards commented
Another consideration is domain aliasing. For example, these are equivalent:
JohnDoe@gmail.com
John.Doe@googlemail.comAs can be:
JaneDoe@outlook.com
JaneDoe@hotmail.com
JaneDoe@msn.com
JaneDoe@live.com -
Robert Headley commented
I just posted a similar suggestion. Google also uses periods in the email address for filtering. so email@gmail.com and e.mail@gmail.com will go to the same user, but like + syntax, it allows you to filter those messages.
-
That's along the lines of what I've been considering Nate, the main challenge is that when someone searches for an address without a plus in it, I need to be able to pull back the address WITH the plus in it. This means that I need to store a reference in the table without the plus which the current data scheme doesn't support.
Right now, there's a key and then a comma delimited list of impacted breaches. I'd need to add the account with the plus along the breach and not only that, but there could by MANY instances of accounts with a plus on the same breach for the same user. For example, let's say that again foo@bar.com on Adobe I need to support foo+1@bar.com and foo+2@bar.com. Now we're talking about a collection of related addresses against the occurrence of the master address next to the breach.
I don't mind adding an extra table query for the rare instance where the plus symbol is used and I also don't mind iterating back through every existing row for a bulk update of some kind, the main thing is that for the 99%+ of searches where there's no plus, I don't want to add an overhead for those guys.
-
Nate Kerkhofs commented
slight correction: in 2b, "it" refers to the main table.
-
Nate Kerkhofs commented
I think a possible solution would be the following:
1. add an extra table for addresses with a + in them, with a relationship to the main table;
2. when an address with a +is added, do 2 things:
a. add the address WITHOUT the + to the main table;
b. add the address WITH the plus to the second table with a link to it.
3. When a user queries an address that has a stored plus value, you can retrieve all values from the other table and show them somewhere to the user (for example, below the breach it's from).This means you store all mails in the same method, namely always without the plus, but you can easily (single query) retrieve the value with the plus. It also seems to me like it's something that can quite easily be implemented (I think I could implement it myself, and I'm only a junior developer). The biggest downsides:
1. it takes slightly longer to import the breaches because you have to transform the pluses;
2. if the address has a + in there, you need an extra query to retrieve them, slightly affecting performance and possibly costing extra;
3. you need to develop a one-time transformation which can deal with the existing records (probably the most complicated part). -
Totally right @anonymous, it's resolving the relationship between x+y@ and x@ that's the tricky bit. It'd be easy just to allow the breach to be found when searching for x@ (I'd just add it as a standalone record), but there's no construct at present to turn that around and advise the user that x@ was breached by virtue of x+y@ being breached.
-
Anonymous commented
I have a Google apps with a unique domain, so obviously searching using the domain works, but for people using this with gmail (or similar that allows that feature) that doesn't work.
The tough part is making x+y@domain.com equal to x@domain.com but also display x+y.
-
Syntax commented
I would love to have this feature, then I would implement the "+" syntax now that HIBP detect it too.
Good idea Troy :)