Skip to content

Nate Kerkhofs

← Customer feedback for Have I Been Pwned

My feedback

1 result found

  1. Enable search and notifications for email addresses using the "+" syntax

    2,568 votes
    Vote

    We're glad you're here

    Please sign in to leave feedback
    Signed in as (Sign out)
    Close
    Close
    You have left! (?) (thinking…)
    113 comments  ·  General  ·  Admin →
    How important is this to you?

    We're glad you're here

    Please sign in to leave feedback
    Signed in as (Sign out)
    Close
    Close
    An error occurred while saving the comment
    Nate Kerkhofs commented  · 

    slight correction: in 2b, "it" refers to the main table.

    An error occurred while saving the comment
    Nate Kerkhofs commented  · 

    I think a possible solution would be the following:

    1. add an extra table for addresses with a + in them, with a relationship to the main table;
    2. when an address with a +is added, do 2 things:
    a. add the address WITHOUT the + to the main table;
    b. add the address WITH the plus to the second table with a link to it.
    3. When a user queries an address that has a stored plus value, you can retrieve all values from the other table and show them somewhere to the user (for example, below the breach it's from).

    This means you store all mails in the same method, namely always without the plus, but you can easily (single query) retrieve the value with the plus. It also seems to me like it's something that can quite easily be implemented (I think I could implement it myself, and I'm only a junior developer). The biggest downsides:

    1. it takes slightly longer to import the breaches because you have to transform the pluses;
    2. if the address has a + in there, you need an extra query to retrieve them, slightly affecting performance and possibly costing extra;
    3. you need to develop a one-time transformation which can deal with the existing records (probably the most complicated part).

Feedback and Knowledge Base

(thinking…)